セットアップを全面的にuvへ切り替え #121
Merged
セットアップを全面的にuvへ切り替え #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimizukawa
force-pushed
the
uv-ing
branch
5 times, most recently
from
27f9f3d to
1864cba
Compare
shimizukawa
commented
Nov 4, 2024
Comment on lines
+30
to
+34
| - name: Install the latest version of uv | ||
| uses: astral-sh/setup-uv@v3 | ||
| with: | ||
| path: | | ||
| ~/.cache/pip | ||
| ~/.local/ | ||
| key: ${{ runner.os }}-pip-${{ hashFiles('requirements.txt') }}-${{ steps.get-date.outputs.yyyymm }} | ||
| version: "latest" | ||
| enable-cache: true |
There was a problem hiding this comment.
| pip3 freeze | ||
| echo "python version $(uv run python --version) running" | ||
| echo "uv version $(uv --version) running" | ||
| uv sync |
There was a problem hiding this comment.
uv sync の実行速度（キャッシュなし）
$ rm -Rf ~/.local
$ rm -Rf ~/.cache/uv
$ time uv sync
real 0m1.535s
user 0m1.102s
sys 0m0.868s
| run: | | ||
| echo "python version $(python3 --version) running" | ||
| echo "pip version $(pip3 --version) running" | ||
| python3 -m pip install -U pip setuptools |
There was a problem hiding this comment.
pip installの実行速度（キャッシュ無し）
$ rm -Rf ~/.cache/pip
$ python -m venv venv
$ source venv/bin/activate
$ time pip install -r requirements.txt
real 0m1.535s
user 0m1.102s
sys 0m0.868s
|
|
||
| uv venv --allow-existing ~/.local | ||
| uv pip install --prefix ~/.local/ -r requirements.txt | ||
| uv venv --allow-existing ${UV_PROJECT_ENVIRONMENT} |
There was a problem hiding this comment.
.local をPython環境として使うためvenvで上書き
| "ghcr.io/devcontainers/features/git:1": {}, | ||
| }, | ||
| "name": "Default Linux Universal", | ||
| "image": "mcr.microsoft.com/devcontainers/universal:2-linux", |
There was a problem hiding this comment.
デフォルトイメージを利用。
github codespacesでキャッシュされていて速いので。
（devcontainer使う人はだいたいcodespacesでしょう、という前提）
| }, | ||
| "name": "Default Linux Universal", | ||
| "image": "mcr.microsoft.com/devcontainers/universal:2-linux", | ||
| "features": {}, |
There was a problem hiding this comment.
デフォルトイメージにはgitがデフォルトで同梱されているため、追加インストールなし
|
|
||
| "onCreateCommand": "bash .devcontainer/on_create_command.sh" | ||
| "containerEnv": { | ||
| "UV_PROJECT_ENVIRONMENT": "/home/codespace/.local" |
There was a problem hiding this comment.
uv sync のインストール先を設定。
codespace 部分は remoteUser だけど環境変数で指定する方法が分からず直接指定。
Comment on lines
+2
to
+3
| uv self update | ||
| uv sync |
There was a problem hiding this comment.
devcontainer起動時にuv自体の更新と、インストールパッケージを最新化
| @@ -1,13 +1,28 @@ | |||
| FROM python:3.8-slim | |||
| FROM python:3.12-slim | |||
Comment on lines
+3
to
+4
| RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \ | ||
| --mount=type=cache,target=/var/lib/apt,sharing=locked \ |
There was a problem hiding this comment.
apt cacheを後から消すのではなく、cacheをdocker cacheに逃がす
tkoyama010
requested changes
Nov 4, 2024
tkoyama010
approved these changes
Nov 4, 2024
Co-authored-by: Go.YAMADA <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• pyproject.tomlファイルを新規追加し、プロジェクト依存関係の管理方法をuvに変更
• devcontaienrの設定をuv前提に更新
• Dockerfileをuv前提に更新
• GitHub Actionsワークフローをuvを使用するように変更
• READMEの説明を更新