Move mypy test module exclusions to per-module ignores #13265
+93
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mypy passes locally for me, as |
|
I don't mind a finer-grained exclusion but sometimes it's a pain to update when you add a new test file. I think I encountered the current failures because Concerning the failure it might be because of a local cache. Now, the reason why I used that ignore-list is because of that:
|
|
If you have a moment, could you try running mypy with this PR? If it is a CI caching issue then we can look at that, but it might be a Linux vs Windows issue. |
|
Mmh. That's weird. It passes locally as well. I've run this: $ mypy --config-file=pyproject.toml --no-incremental tests
Warning: unused section(s) in pyproject.toml: module = ['pypi_attestations', 'sigstore.models', 'sigstore.verify', 'sigstore.verify.policy', 'tests.test_abc']
Success: no issues found in 165 source filesAnd running only |
|
If you get rid of [[tool.mypy.overrides]]
module = ["tests.test_util.typing_test_data"]
ignore_errors = trueand this will work and IMO be more consistent - having one way to do excludes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
I think this is the right thing to do -- we switch from blanket exclusions of the test modules to finer-grained per-module ignores. This won't catch mutch at the moment as most functions are still untyped, but it has found e.g.
node.getattr(...)->getattr(node, ...). I'd welcome feedback though, as mypy config for the tests has changed a few times. I also don't know if we should attemt a similar thing for Pyright yet.cc @danieleades who originally introduced suggested type-checking for
tests/in #12097.A
References
tests/directory #12097