Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the thumbnail cursor #29

Merged
merged 3 commits into from
Aug 2, 2022
Merged

Conversation

12rambau
Copy link
Member

@12rambau 12rambau commented Nov 21, 2021

  • change the cursor from the link pointer to the zoom-in one.
  • when I built the doc, _build and _image folders were not ignored, I changed the .gitignore accordingly

Fix #28

t-b added a commit to AllenInstitute/MIES that referenced this pull request Nov 22, 2021
This is more natural, fix taken from [1].

[1]: sphinx-contrib/images#29
@jonascj
Copy link
Collaborator

jonascj commented Aug 1, 2022

Thank you for pushing forward with this @12rambau . It looks fine, but let me test it tomorrow before merging.

Before releasing with this I'd like a few days to re-review #23 and #31. Maybe they are ready to go as well. If not, we can release with this small change, and again later when #23 and #31 are ready.

@jonascj jonascj merged commit 30b50b8 into sphinx-contrib:master Aug 2, 2022
@jonascj
Copy link
Collaborator

jonascj commented Aug 2, 2022

@12rambau I've tested your PR and everything seem in order. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change the mouse pointer ?
2 participants