Avoid buffer copies during writes.

Signed-off-by: Santiago Pericasgeertsen <[email protected]>
spericas · Jan 10, 2024 · 88e3ba8 · 88e3ba8
1 parent afa735d
commit 88e3ba8
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 2 deletions.
diff --git a/common/buffers/src/main/java/io/helidon/common/buffers/CompositeArrayBufferData.java b/common/buffers/src/main/java/io/helidon/common/buffers/CompositeArrayBufferData.java
@@ -38,7 +38,24 @@ public BufferData rewind() {
 
     @Override
     public void writeTo(OutputStream out) {
-        copy().writeTo(out);
+        if (data.length == 1) {
+            data[0].writeTo(out);
+        } else {
+            copy().writeTo(out);
+        }
+        /*
+        for (BufferData datum : data) {
+            if (datum instanceof CompositeBufferData) {
+                datum.writeTo(out);
+            } else {
+                int available = datum.available();
+                if (available > 0) {
+                    datum.writeTo(out);
+                    datum.skip(-available);
+                }
+            }
+        }
+         */
     }
 
     @Override

diff --git a/common/buffers/src/main/java/io/helidon/common/buffers/CompositeListBufferData.java b/common/buffers/src/main/java/io/helidon/common/buffers/CompositeListBufferData.java
@@ -56,7 +56,24 @@ public BufferData rewind() {
 
     @Override
     public void writeTo(OutputStream out) {
-        copy().writeTo(out);
+        if (data.size() == 1) {
+            data.get(0).writeTo(out);
+        } else {
+            copy().writeTo(out);
+        }
+        /*
+        for (BufferData datum : data) {
+            if (datum instanceof CompositeBufferData) {
+                datum.writeTo(out);
+            } else {
+                int available = datum.available();
+                if (available > 0) {
+                    datum.writeTo(out);
+                    datum.skip(-available);
+                }
+            }
+        }
+         */
     }
 
     @Override