Avoid buffer copies during writes.

Signed-off-by: Santiago Pericasgeertsen <[email protected]>
spericas · Jan 10, 2024 · 7eb69f4 · 7eb69f4
1 parent afa735d
commit 7eb69f4
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 4 deletions.
diff --git a/common/buffers/src/main/java/io/helidon/common/buffers/CompositeArrayBufferData.java b/common/buffers/src/main/java/io/helidon/common/buffers/CompositeArrayBufferData.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2022 Oracle and/or its affiliates.
+ * Copyright (c) 2022, 2024 Oracle and/or its affiliates.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -38,7 +38,17 @@ public BufferData rewind() {
 
     @Override
     public void writeTo(OutputStream out) {
-        copy().writeTo(out);
+        for (BufferData datum : data) {
+            if (datum instanceof CompositeBufferData) {
+                datum.writeTo(out);
+            } else {
+                int available = datum.available();
+                if (available > 0) {
+                    datum.writeTo(out);
+                    datum.skip(-available);
+                }
+            }
+        }
     }
 
     @Override

diff --git a/common/buffers/src/main/java/io/helidon/common/buffers/CompositeListBufferData.java b/common/buffers/src/main/java/io/helidon/common/buffers/CompositeListBufferData.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2022 Oracle and/or its affiliates.
+ * Copyright (c) 2022, 2024 Oracle and/or its affiliates.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -56,7 +56,17 @@ public BufferData rewind() {
 
     @Override
     public void writeTo(OutputStream out) {
-        copy().writeTo(out);
+        for (BufferData datum : data) {
+            if (datum instanceof CompositeBufferData) {
+                datum.writeTo(out);
+            } else {
+                int available = datum.available();
+                if (available > 0) {
+                    datum.writeTo(out);
+                    datum.skip(-available);
+                }
+            }
+        }
     }
 
     @Override