Makes ErrorHandling not optional in ListenerConfig by specifying a cr…

…eate method.
spericas · Feb 24, 2025 · 5e71e9f · 5e71e9f
1 parent 4a6e302
commit 5e71e9f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 22 deletions.
diff --git a/webserver/http2/src/main/java/io/helidon/webserver/http2/Http2ServerStream.java b/webserver/http2/src/main/java/io/helidon/webserver/http2/Http2ServerStream.java
@@ -312,23 +312,16 @@ public void run() {
             // gather error handling properties
             ErrorHandling errorHandling = ctx.listenerContext()
                     .config()
-                    .errorHandling()
-                    .orElse(null);
-            boolean includeEntity = false;
-            boolean logAllMessages = false;
-            if (errorHandling != null) {
-                includeEntity = errorHandling.includeEntity();
-                logAllMessages = errorHandling.logAllMessages();
-            }
+                    .errorHandling();
 
             // log message in DEBUG mode
-            if (LOGGER.isLoggable(DEBUG) && (e.safeMessage() || logAllMessages)) {
+            if (LOGGER.isLoggable(DEBUG) && (e.safeMessage() || errorHandling.logAllMessages())) {
                 LOGGER.log(DEBUG, e);
             }
 
             // create message to return based on settings
             String message = null;
-            if (includeEntity) {
+            if (errorHandling.includeEntity()) {
                 message = e.safeMessage() ? e.getMessage() : "Bad request, see server log for more information";
             }
 

diff --git a/webserver/webserver/src/main/java/io/helidon/webserver/ListenerConfigBlueprint.java b/webserver/webserver/src/main/java/io/helidon/webserver/ListenerConfigBlueprint.java
@@ -403,8 +403,9 @@ default void configureSocket(ServerSocket socket) {
     /**
      * Configuration for this listener's error handling.
      *
-     * @return optional error handling
+     * @return error handling
      */
     @Option.Configured
-    Optional<ErrorHandling> errorHandling();
+    @Option.DefaultMethod("create")
+    ErrorHandling errorHandling();
 }
diff --git a/webserver/webserver/src/main/java/io/helidon/webserver/http1/Http1Connection.java b/webserver/webserver/src/main/java/io/helidon/webserver/http1/Http1Connection.java
@@ -648,23 +648,16 @@ private void handleRequestException(RequestException e) {
         // gather error handling properties
         ErrorHandling errorHandling = ctx.listenerContext()
                 .config()
-                .errorHandling()
-                .orElse(null);
-        boolean includeEntity = false;
-        boolean logAllMessages = false;
-        if (errorHandling != null) {
-            includeEntity = errorHandling.includeEntity();
-            logAllMessages = errorHandling.logAllMessages();
-        }
+                .errorHandling();
 
         // log message in DEBUG mode
-        if (LOGGER.isLoggable(DEBUG) && (e.safeMessage() || logAllMessages)) {
+        if (LOGGER.isLoggable(DEBUG) && (e.safeMessage() || errorHandling.logAllMessages())) {
             LOGGER.log(DEBUG, e);
         }
 
         // create message to return based on settings
         String message = null;
-        if (includeEntity) {
+        if (errorHandling.includeEntity()) {
             message = e.safeMessage() ? e.getMessage() : "Bad request, see server log for more information";
         }