Avoid buffer copies during writes.

Signed-off-by: Santiago Pericasgeertsen <[email protected]>
spericas · Jan 8, 2024 · 490b05b · 490b05b
1 parent afa735d
commit 490b05b
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/common/buffers/src/main/java/io/helidon/common/buffers/CompositeArrayBufferData.java b/common/buffers/src/main/java/io/helidon/common/buffers/CompositeArrayBufferData.java
@@ -38,7 +38,18 @@ public BufferData rewind() {
 
     @Override
     public void writeTo(OutputStream out) {
-        copy().writeTo(out);
+        for (BufferData datum : data) {
+            if (datum.consumed()) {
+                continue;
+            }
+            if (datum instanceof CompositeBufferData) {
+                datum.writeTo(out);
+            } else {
+                int available = datum.available();
+                datum.writeTo(out);
+                datum.skip(-available);
+            }
+        }
     }
 
     @Override

diff --git a/common/buffers/src/main/java/io/helidon/common/buffers/CompositeListBufferData.java b/common/buffers/src/main/java/io/helidon/common/buffers/CompositeListBufferData.java
@@ -56,7 +56,18 @@ public BufferData rewind() {
 
     @Override
     public void writeTo(OutputStream out) {
-        copy().writeTo(out);
+        for (BufferData datum : data) {
+            if (datum.consumed()) {
+                continue;
+            }
+            if (datum instanceof CompositeBufferData) {
+                datum.writeTo(out);
+            } else {
+                int available = datum.available();
+                datum.writeTo(out);
+                datum.skip(-available);
+            }
+        }
     }
 
     @Override