Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to include Rover MEMS trigger patterns #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mike501
Copy link
Contributor

@mike501 mike501 commented Jan 10, 2021

Covers all four patterns used by rover with cam for the 3 most recent.

@DonPasquale
Copy link

Merging this into Ardu-Stim master would be fantastic!

Rover used the MEMS obviously for various engines, but the early pattern 36-1-1 (MEMS 1.0, 1.3, 1.6) was in particular used on the A-series engines in the classic Mini SPI from ca. 1992 to 1996. And although this doesn't allow even semi-sequential, you just keep (and lock) your dizzy and still have way better resolution for ign timing.

So: yes, please! :-)

Mike501 and noisymime: thank you very much!

@mike501
Copy link
Contributor Author

mike501 commented Feb 10, 2021

Don, I've done the code in such a way that using the 36-1-1 pattern if you generate a cam signal, you can go fully sequential. This could be (I think) as simple as the rotar arm from the dizzy having 5v through it on cylinder 3 or 4 with the advance locked.

If you want to test the speeduino code let me know.

Copy link

@DonPasquale DonPasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only minor suggestion I would have is to slightly rename lines 117-120 in order to reflect that this is not limited to the Rover K-series engines, but applies to all engines equipped with the Rover MEMS ( https://en.wikipedia.org/wiki/Modular_Engine_Management_System ).

May I therefore kindly propose to write:

"ROVER_MEMS_MODE..."

instead of:

"ROVER_K_MODE..."

Thank you.

@mike501
Copy link
Contributor Author

mike501 commented Aug 9, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants