-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to include Rover MEMS trigger patterns #16
base: master
Are you sure you want to change the base?
Conversation
Covers all four patterns
Merging this into Ardu-Stim master would be fantastic! Rover used the MEMS obviously for various engines, but the early pattern 36-1-1 (MEMS 1.0, 1.3, 1.6) was in particular used on the A-series engines in the classic Mini SPI from ca. 1992 to 1996. And although this doesn't allow even semi-sequential, you just keep (and lock) your dizzy and still have way better resolution for ign timing. So: yes, please! :-) Mike501 and noisymime: thank you very much! |
Don, I've done the code in such a way that using the 36-1-1 pattern if you generate a cam signal, you can go fully sequential. This could be (I think) as simple as the rotar arm from the dizzy having 5v through it on cylinder 3 or 4 with the advance locked. If you want to test the speeduino code let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only minor suggestion I would have is to slightly rename lines 117-120 in order to reflect that this is not limited to the Rover K-series engines, but applies to all engines equipped with the Rover MEMS ( https://en.wikipedia.org/wiki/Modular_Engine_Management_System ).
May I therefore kindly propose to write:
"ROVER_MEMS_MODE..."
instead of:
"ROVER_K_MODE..."
Thank you.
Fair comment - I think in the actual firmware code I don't mention the k
series just rover mems. Will update this when I've finished the current
trigger pattern project
…On Mon, 9 Aug 2021, 15:05 DonPasquale, ***@***.***> wrote:
***@***.**** commented on this pull request.
The only minor suggestion I would have is to slightly rename lines 117-120
in order to reflect that this is not limited to the Rover K-series engines,
but applies to all engines equipped with the Rover MEMS (
https://en.wikipedia.org/wiki/Modular_Engine_Management_System ).
May I therefore kindly propose to write:
"ROVER_MEMS_MODE..."
instead of:
"ROVER_K_MODE..."
Thank you.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#16 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AONMGMGTNE7XURZ27BFWQW3T37OBJANCNFSM4V4XLG3Q>
.
|
Covers all four patterns used by rover with cam for the 3 most recent.