Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client connect: expected Node response #27

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jonas089
Copy link

The node actually returns:

{"id":"cd8d0441","url":"wss://node.spectre-network.org/"}

not:

{"uid":"cd8d0441","url":"wss://node.spectre-network.org/"}

Screenshot 2024-11-23 at 15 35 40

Therefore I chose to change the expected identifier in the wallet client to match the response data.

@jonas089 jonas089 closed this Nov 23, 2024
@jonas089 jonas089 reopened this Nov 24, 2024
@jonas089
Copy link
Author

I tested it and it works @x100111010. You might wanna verify & merge.

@jonas089
Copy link
Author

jonas089 commented Nov 24, 2024

Screenshot 2024-11-24 at 12 06 40

Here is proof that it works (and my wallet ;)

@0xA001113
Copy link
Member

@jonas089 Let me review it a bit later. With the merge of upstream changes into 0.3.16 we've also merged inscription related changes which require v2 resolver infrastructure. Anyway the change is much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants