chore(server/healthcheck): remove postgres from readiness probe (#3820)

* chore(server/healthcheck): remove postgres from readiness probe - instead rely on number of available free connections - reduce period over which we are averaging the available free connections to 4s
specklesystems · Jan 14, 2025 · e349ff3 · e349ff3
1 parent 3351e09
commit e349ff3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 36 deletions.
diff --git a/packages/server/healthchecks/health.ts b/packages/server/healthchecks/health.ts
@@ -88,35 +88,9 @@ export const handleLivenessFactory =
 
 export const handleReadinessFactory = (deps: {
   isRedisAlive: RedisCheck
-  areAllPostgresAlive: MultiDBCheck
   getFreeConnectionsCalculators: () => FreeConnectionsCalculators
 }): ReadinessHandler => {
   return async () => {
-    const allPostgresResults = await deps.areAllPostgresAlive()
-    const deadPostgresKeys = Object.entries(allPostgresResults)
-      .filter((result) => !result[1].isAlive)
-      .map((result) => result[0])
-
-    if (deadPostgresKeys.length) {
-      throw new ReadinessError(
-        `Readiness health check failed. Postgres for ${join(
-          deadPostgresKeys,
-          ', '
-        )} is not available.`,
-        {
-          cause: new MultiError(
-            Object.entries(allPostgresResults).map((kv) =>
-              ensureErrorOrWrapAsCause(
-                //HACK: kv[1] is not typed correctly as the filter does not narrow the type
-                (kv[1] as { isAlive: false; err: unknown }).err,
-                'Unknown Postgres error.'
-              )
-            )
-          )
-        }
-      )
-    }
-
     const redisClient = getGenericRedis()
     const redisCheck = await deps.isRedisAlive({ client: redisClient })
     if (!redisCheck.isAlive) {
@@ -149,14 +123,11 @@ export const handleReadinessFactory = (deps: {
 
     return {
       details: {
-        postgres: merge(
-          allPostgresResults,
-          Object.fromEntries(
-            Object.entries(percentageFreeConnections).map(([k, v]) => [
-              k,
-              { percentageFreeConnections: v.toFixed(0) }
-            ])
-          )
+        postgres: Object.fromEntries(
+          Object.entries(percentageFreeConnections).map(([k, v]) => [
+            k,
+            { percentageFreeConnections: v.toFixed(0) }
+          ])
         ),
         redis: true
       }

diff --git a/packages/server/healthchecks/index.ts b/packages/server/healthchecks/index.ts
@@ -44,7 +44,7 @@ export const updateFreeDbConnectionSamplers = async () => {
         knexFreeDbConnectionSamplerFactory({
           db: dbClient.client,
           collectionPeriod: highFrequencyMetricsCollectionPeriodMs(),
-          sampledDuration: 20_000 //number of ms over which to average the database connections, before declaring unready. 20 seconds.
+          sampledDuration: 4_000 //number of ms over which to average the database connections, before declaring unready. 4 seconds.
         })
       knexFreeDbConnectionSamplerReadiness[dbClient.regionKey].start()
     }
@@ -71,7 +71,6 @@ export const initFactory: () => (
 
     const readinessHandler = handleReadinessFactory({
       isRedisAlive,
-      areAllPostgresAlive,
       getFreeConnectionsCalculators: getKnexFreeDbConnectionSamplerReadiness
     })