Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove silent option when setting specify user in QCBX #6215

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Conversation

sharadsw
Copy link
Contributor

@sharadsw sharadsw commented Feb 10, 2025

Fixes #6199

Setting the specify user with the silent mode led to the save blocker not detecting the change and blocking save until a re-render occurred. This couldn't be reproduced locally because of strict mode, which renders everything twice in dev mode.

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add automated tests
  • Add relevant issue to release milestone
  • Add relevant documentation (Tester - Dev)
  • Add a reverse migration if a migration is present in the PR

Testing instructions

  • Create a CO query
  • Select a few COs and click on Create Record Set
  • Verify save is not blocked due to the owner field

- Fixes specify user not being detected by save blocker when creating a record set
@sharadsw sharadsw added this to the 7.10 milestone Feb 10, 2025
@sharadsw sharadsw requested review from CarolineDenis and a team February 10, 2025 17:31
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify save is not blocked due to the owner field

Looks good, save is no longer blocked!

@emenslin emenslin requested a review from a team February 10, 2025 18:40
Copy link
Contributor

@Areyes42 Areyes42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify save is not blocked due to the owner field

No more save block 👍

@sharadsw sharadsw merged commit d114d84 into production Feb 10, 2025
12 checks passed
@sharadsw sharadsw deleted the issue-6199 branch February 10, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Record Set Save Blocked despite auto-filled Owner field
4 participants