Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary warnings for creation infos in the graph #12

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Remove unnecessary warnings for creation infos in the graph #12

merged 1 commit into from
Jan 7, 2025

Conversation

goneall
Copy link
Member

@goneall goneall commented Jan 6, 2025

Partial fix for spdx/tools-java#170

@goneall goneall requested a review from bact January 6, 2025 23:58
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

bact
bact approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the intension is to only emits a warning if the model object is not an instance of CreationInfo, LGTM.

@goneall goneall merged commit 2f87b9b into main Jan 7, 2025
3 checks passed
@goneall goneall deleted the removewarn branch January 7, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bact bact bact approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goneall @bact