Fix read_and_write_sets() for ControlFlowRegion #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phschaad
requested changes
Feb 4, 2025
dace/sdfg/sdfg.py
Outdated
| for edge in self.all_interstate_edges(): | ||
| read_set |= edge.data.free_symbols & array_names | ||
|
|
||
| # By definition, data that is referenced by the conditions (branching condition, |
There was a problem hiding this comment.
This comment appears copied from somewhere else, does this really apply here?
There was a problem hiding this comment.
I think it does. We are removing from single_use_data the symbols used by condition expressions in control flow regions.
There was a problem hiding this comment.
But what is single_use_data here, in this context? It appears that all we are doing here - based on the code - is adding symbols used on control flow region's meta accesses (conditions, loop increments, etc.) to the read_set of the SDFG?
There was a problem hiding this comment.
Now I get it, the misleading information is "single use data". I will change the code comment.
Co-authored-by: Philip Mueller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PruneConnectorstransformation relies onread_and_write_sets()to identify connectors on a nested SDFG that refer to unused data containers. With the introduction ofControlFlowRegionnodes, the data containers can now be accessed by symbolic expressions used as conditions in such nodes. This case was not considered in baseline.