CI (verilator compatibility): revive monthly compatibility check #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanc
force-pushed
the
checkout-submodules-with-action
branch
from
db5ceb6 to
066d1e8
Compare
added 2 commits
January 6, 2025 09:12
The action `BSFishy/pip-action@v1` is forbidden to run as part of this repository's GH actions preventing this workflow to run successfully in the last two years. I see two ways to fix this 1. Call pip install directly (as suggested in this PR) 2. Add an exception (in the security settings) to allow that particular action.
Configure the `actions/checkout` to fetch submodules recursively instead of adding a separate step doing the same manually.
romanc
force-pushed
the
checkout-submodules-with-action
branch
from
066d1e8 to
69104a4
Compare
romanc
changed the title
romanc
force-pushed
the
checkout-submodules-with-action
branch
from
49e320c to
d9a6522
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to fix the monthly verilator compatibility tests. This overview shows that they were failing for the last year. Do we still care about these tests or should we maybe get rid of the workflow?