-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FPGA tutorial #1438
Draft
TizianoDeMatteis
wants to merge
12
commits into
main
Choose a base branch
from
fpga_tutorial
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
FPGA tutorial #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbennun
requested changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No inline comments:
- date -> dace
- explict -> explicit
- commented code blocks can just be code blocks with a comment in them
- optmize -> optimize
- "library nodes Library nodes" -> "library nodes. Library nodes are high-level nodes that can represent a wide variety of operators. In this case, the two matrix multiplications"...
- "expension this FPGA" -> "expansion. This FPGA"
- "expensions" -> "expansions" (apply everywhere)
- "need of off-chip" -> "need for off-chip"
- "multiple memory buffer being" -> "multiple memory buffers being"
- "we can distributed" -> "we can distribute"
- ", that" -> ", which"
- "of its program" -> "of their program"
- "applying DaCe auto-optimization heuristic" -> either "heuristics" or "the DaCe". The former is likely better
- "a set of simplification to" -> "a set of simplification passes to"
- "of the [...] ones" -> "of [...]."
- "can not currently being tuned by the user." - what does this mean?
- "Let's start again from the SDFG parsing" -> "Let's start again from parsing the SDFG"
- "explicitely" -> "explicitly"
- "execute FPGA program" -> "execute FPGA programs"
- "properly" -> ""
- "For example, to enable Hardware execution via command line (other" -> "Hardware execution can be enabled via the command line, or other"
- "as follow" -> "as follows"
- ", that" -> ", which"
- "bistream" -> "bitstream"
- "executed the program" -> "execute the program"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, these should be fixed now.
tbennun
approved these changes
Nov 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic FPGA tutorial.
The run jupyter notebook can be accessed here: https://nbviewer.org/github/spcl/dace/blob/fpga_tutorial/tutorials/fpga.ipynb
**Note: ** currently there are glitches in the rendered notebook