Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated handling of duplicate devices. #11

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Updated handling of duplicate devices. #11

merged 2 commits into from
Oct 17, 2024

Conversation

canismarko
Copy link
Contributor

Previously, the old device would be retained and the new device would be ignored. Now, the new device overwrites the old device.

Also, the warning for a duplicate name is only issued for the top level devices in the device hierarchy.

Fixes:

Previously, the old device would be retained and the new device would
be ignored. Now, the new device overwrites the old device.

Also, the warning for a duplicate name is only issued for the top
level devices in the device hierarchy.
@canismarko canismarko added the enhancement New feature or request label Oct 16, 2024
Copy link
Contributor

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@canismarko canismarko merged commit 325050f into main Oct 17, 2024
2 checks passed
@canismarko canismarko deleted the warnings branch October 17, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants