XRF viewer display to work with new ophyd-async Xspress device #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sterbinsky
reviewed
Jan 14, 2025
| attribute. The number of mcas is determined by passing *elements* | ||
| when initializing an object. *elements* can be either an integer, | ||
| in which case it represents to number of elements, or an | ||
| interator, representing the index of each element. |
There was a problem hiding this comment.
probable spelling error -> 'interator' should be 'iterator'
sterbinsky
reviewed
Jan 16, 2025
| _controller: DetectorController | ||
| _writer: adcore.ADHDFWriter | ||
|
|
||
| def __init__( | ||
| self, | ||
| prefix: str, | ||
| path_provider: PathProvider | None = None, | ||
| elements: int | Sequence[int] = 1, | ||
| ev_per_bin: float = 10.0, | ||
| drv_suffix="det1:", |
There was a problem hiding this comment.
Is eV per bin user adjustable? This is possible for dxp, but maybe not xspress3. I'm not so familiar with the xspress3
sterbinsky
reviewed
Jan 16, 2025
| _spectrum_channels: Sequence | ||
| _selected_mca: int = None | ||
| _mca_lower_receiver = None | ||
| _mca_upper_receiver = None | ||
|
|
||
| _spectra: dict | ||
|
|
There was a problem hiding this comment.
I've not seen this syntax. What does the colon do?
sterbinsky
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The window has been stripped down. ROI selection has been removed and the window now shows a list of elements with their counts and dead-time %s, along with control, and the individual element spectra.
The x-axis now shows energy instead of bins.
The legend of the plot jumps around in how it's ordered, perhaps in future we can find a way to fix this? For now it seemed tied in with the way the plotting is done and didn't seem like a big enough problem to justify fixing.
It would be nice to restore the onHover behavior from previously: if an element's row is hovered over, only that spectrum is show in the plot.
Things to do before merging:
write docsupdate iconfig_testing.toml