Added back the shutter selector to the voltmeters display. #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canismarko
force-pushed
the
dark_current_shutter
branch
from
1e7a477 to
18a004c
Compare
|
Ready to be tested at the beamline. |
Cathyhjj
reviewed
Dec 19, 2024
| for idx in range(self.ui.shutter_combobox.count()): | ||
| self.ui.shutter_combobox.removeItem(idx) | ||
| # Add the shutters to the shutter combobox | ||
| shutters = registry.findall("shutters", allow_none=True) |
There was a problem hiding this comment.
I would like explicitly remove 'front end shutter' from the list because it happens very often that ppl accidentally choose front end shutter.
There was a problem hiding this comment.
I agree that the FES should not be available.
Instead of hard-coding the name "front_end_shutter", though, I used the existing allow_close and allow_open attributes on the shutter devices. The shutter will only be present if both are not False. A corollary is that shutters without those attributes will still be allowed.
src/firefly/tests/test_voltmeters.py
Outdated
| assert checkbox.isEnabled() | ||
| # Check that shutters were added to the combobox | ||
| combobox_items = [combobox.itemText(idx) for idx in range(combobox.count())] | ||
| assert "front_end_shutter" in combobox_items |
There was a problem hiding this comment.
If we decided to remove front end shutter, the test should be modified too
Cathyhjj
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things to do before merging:
write docsupdate iconfig_testing.toml