Firefly-Queueserver improvements #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tic timeout instead.
|
Tests won't pass until #320 is merged. |
sterbinsky
reviewed
Dec 22, 2024
sterbinsky
reviewed
Dec 22, 2024
sterbinsky
reviewed
Dec 22, 2024
src/firefly/queue_client.py
Outdated
| next(self.status) # Prime the generator | ||
|
|
||
| def start(self): | ||
| # Start the time so that it |
There was a problem hiding this comment.
comment appears incomplete
sterbinsky
approved these changes
Dec 22, 2024
|
Thanks @sterbinsky. I made those changes and will merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bps.mvto be added to the queueserver.Things to do before merging: