Ophyd-async support for the Xspress3 family of detectors #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canismarko
force-pushed
the
async-xspress
branch
from
a28bab8 to
8aa10e1
Compare
4 tasks
|
Tests will fail until #320 is merged. |
|
I am ready to review the PR, and then found it merged. I will skip this task.
Sincerely,
Yanna
… On Dec 21, 2024, at 13:51, Mark Wolfman ***@***.***> wrote:
Merged #316 <#316> into main.
—
Reply to this email directly, view it on GitHub <#316 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A4OQE566DUXADRJMCKOSHFL2GXBETAVCNFSM6AAAAABSWMZFYOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVG42DAMJZGI4TGMI>.
You are receiving this because your review was requested.
|
Ah, yeah. I realized @Cathyhjj already partially reviewed this indirectly, so I merged to work on other things that need it. It could use some more scrutiny when we have access to real hardware again, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Xspress3 pulse processor electronics using ophyd-async devices. Not many bells-and-whistles; just a detector that saves the area detector frames to disk so they can be read out by Tiled.
One thing I discovered while writing this, erasing the Xspress3 detector triggers a new, blank frame to be sent to the plugins. One implication of this is that the detector needs to be erased before starting the HDF writer plugin, and erase_on_start needs to be off.
Support has not been removed for the previous threaded Ophyd support.
Things to do before merging: