Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Things fixed to work with Guarneri #312

Merged
merged 11 commits into from
Dec 5, 2024
Merged

Things fixed to work with Guarneri #312

merged 11 commits into from
Dec 5, 2024

Conversation

canismarko
Copy link
Contributor

@canismarko canismarko commented Nov 22, 2024

This PR switches instrument loading out of haven and uses Guarneri instead.

Previously, we had a mechanism for loading devices from a configuration file. This has since been spun off into a new package, guarneri: https://pypi.org/project/guarneri/

This PR removes the previous code that has been moved the guarneri, and adjusts the usage to match the latest Guarneri install.

It also removes the now depracated module haven.device module.

Things to do before merging:

  • add tests
  • write docs
  • update iconfig_testing.toml
  • flake8, black, and isort

@canismarko canismarko marked this pull request as ready for review December 4, 2024 22:57
It will be replaced with an ohpyd-async version developed during
asymmotron beamtime.
``titleize`` function to haven.utils.
@canismarko canismarko merged commit 0ed8d8b into main Dec 5, 2024
1 check passed
@canismarko canismarko deleted the guarneri branch December 5, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants