Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xafs metadata #295

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Xafs metadata #295

merged 3 commits into from
Nov 4, 2024

Conversation

Cathyhjj
Copy link
Collaborator

@Cathyhjj Cathyhjj commented Nov 4, 2024

Things to do before merging:

  • add tests
  • write docs
  • update iconfig_testing.toml
  • flake8, black, and isort

@Cathyhjj Cathyhjj requested a review from canismarko November 4, 2024 16:34
canismarko
canismarko approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@canismarko canismarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to me. I wrote some of the code, though, so might be good to have someone else also review. @Cathyhjj, @yannachen maybe?

@Cathyhjj
Copy link
Collaborator Author

Cathyhjj commented Nov 4, 2024

checked your def test_xafs_metadata, looks good

@canismarko canismarko merged commit 3f79310 into main Nov 4, 2024
1 check passed
@canismarko canismarko deleted the xafs_metadata branch November 24, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canismarko canismarko canismarko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cathyhjj @canismarko