Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] Add support for both single email string and array of email strings #1810

Merged
merged 3 commits into from
Jul 4, 2024
Merged

[9.x] Add support for both single email string and array of email strings #1810

merged 3 commits into from
Jul 4, 2024

Conversation

vrusua
Copy link
Contributor

@vrusua vrusua commented Jul 3, 2024

Fixes issue for 9.x revision described here: Send mail notifications to multiple addresses failed #1291 (comment)

@freekmurze
Copy link
Member

Could you also add a test for this?

@freekmurze freekmurze requested a review from Nielsvanpach July 3, 2024 08:46
@vrusua
Copy link
Contributor Author

vrusua commented Jul 3, 2024

Hi Freek,

I’ve added more tests to handle this in EventHandlerTest.php. Please take a look.

Cheers

@Nielsvanpach
Copy link
Member

Thanks!

@Nielsvanpach Nielsvanpach merged commit 697038a into spatie:main Jul 4, 2024
1 check passed
Nielsvanpach added a commit that referenced this pull request Jul 4, 2024
@Nielsvanpach
fixes for #1810
83ad4a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nielsvanpach Nielsvanpach Awaiting requested review from Nielsvanpach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vrusua @freekmurze @Nielsvanpach