Skip to content

Commit

Permalink
use more config files
Browse files Browse the repository at this point in the history
  • Loading branch information
Nielsvanpach committed Jun 10, 2024
1 parent e67fdc5 commit 556e526
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 1 deletion.
1 change: 1 addition & 0 deletions src/BackupDestination/BackupDestination.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
use Exception;
use Illuminate\Contracts\Filesystem\Factory;
use Illuminate\Contracts\Filesystem\Filesystem;
use Spatie\Backup\Config\Config;
use Spatie\Backup\Exceptions\InvalidBackupDestination;

class BackupDestination
Expand Down
2 changes: 1 addition & 1 deletion src/BackupServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public function packageRegistered(): void

$this->registerDiscordChannel();

$this->app->singleton(Config::class, function () {
$this->app->scoped(Config::class, function () {
return Config::fromArray(config('backup'));
});
}
Expand Down
8 changes: 8 additions & 0 deletions src/Config/Config.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,14 @@ protected function __construct(
) {
}

/** @internal used for testing */
public static function rebind(): void
{
app()->scoped(Config::class, function () {
return self::fromArray(config('backup'));
});
}

/** @param array<mixed> $data */
public static function fromArray(array $data): self
{
Expand Down
4 changes: 4 additions & 0 deletions tests/Commands/BackupCommandTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,8 @@
config()->set('backup.backup.destination.compression_method', ZipArchive::CM_STORE);
config()->set('backup.backup.destination.compression_level', 0);

\Spatie\Backup\Config\Config::rebind();

$this->artisan('backup:run --only-db')->assertExitCode(0);

$zip = new ZipArchive();
Expand All @@ -411,6 +413,8 @@
config()->set('backup.backup.destination.compression_method', ZipArchive::CM_DEFLATE);
config()->set('backup.backup.destination.compression_level', 2);

\Spatie\Backup\Config\Config::rebind();

$this->artisan('backup:run --only-db')->assertExitCode(0);

$zip = new ZipArchive();
Expand Down

0 comments on commit 556e526

Please sign in to comment.