Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Replace @HostBinding with host property of Component Decorator #58

Merged
merged 16 commits into from
Nov 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { HlmToggleDirective } from '@spartan-ng/ui-toggle-helm';
providers: [provideIcons({ radixFontItalic })],
template: `
<button size="lg" brnToggle hlm>
<hlm-icon size="sm" name="radixFontItalic" />
<hlm-icon size="lg" name="radixFontItalic" />
</button>
`,
})
Expand All @@ -33,7 +33,7 @@ import { radixFontItalic } from '@ng-icons/radix-icons';
providers: [provideIcons({ radixFontItalic })],
template: \`
<button size="lg" brnToggle hlm>
<hlm-icon size="sm" name="radixFontItalic" />
<hlm-icon size="lg" name="radixFontItalic" />
</button>
\`,
})
Expand Down
10 changes: 5 additions & 5 deletions apps/app/src/app/shared/breadcrumbs/breadcrumbs.component.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import { NgForOf, NgIf } from '@angular/common';
import { ChangeDetectionStrategy, Component, HostBinding, ViewEncapsulation, inject } from '@angular/core';
import { ChangeDetectionStrategy, Component, ViewEncapsulation, inject } from '@angular/core';
import { toSignal } from '@angular/core/rxjs-interop';
import { RouterLink } from '@angular/router';
import { provideIcons } from '@ng-icons/core';
import { radixChevronRight } from '@ng-icons/radix-icons';
import { HlmIconComponent } from '@spartan-ng/ui-icon-helm';
import { BreadcrumbService } from '~/app/shared/breadcrumbs/breadcrumb.service';
import { BreadcrumbService } from './breadcrumb.service';

export interface Breadcrumb {
label: string;
Expand Down Expand Up @@ -48,10 +48,10 @@ export interface Breadcrumb {
`,
encapsulation: ViewEncapsulation.Emulated,
changeDetection: ChangeDetectionStrategy.OnPush,
host: {
class: '',
},
})
export class BreadcrumbsComponent {
public breadcrumbs = toSignal(inject(BreadcrumbService).breadcrumbs$);

@HostBinding('class')
public class = '';
}
12 changes: 6 additions & 6 deletions apps/app/src/app/shared/layout/container.directive.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import { Directive, HostBinding } from '@angular/core';
import { Directive } from '@angular/core';

@Directive({
selector: '[spartanContainer]',
standalone: true,
host: {
class:
'w-full mx-auto px-1 flex flex-1 items-start md:grid md:grid-cols-[220px_minmax(0,1fr)] lg:grid-cols-[240px_minmax(0,1fr)]',
},
})
export class ContainerDirective {
@HostBinding('class')
public class =
'w-full mx-auto px-1 flex flex-1 items-start md:grid md:grid-cols-[220px_minmax(0,1fr)] lg:grid-cols-[240px_minmax(0,1fr)]';
}
export class ContainerDirective {}
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { Directive, HostBinding } from '@angular/core';
import { Directive } from '@angular/core';

@Directive({
selector: '[spartanSideNavHeading]',
standalone: true,
host: {
class: 'flex items-center justify-between mb-1 rounded-md px-2 py-1 font-semibold',
},
})
export class SideNavHeadingDirective {
@HostBinding('class')
public class = 'flex items-center justify-between mb-1 rounded-md px-2 py-1 font-semibold';
}
export class SideNavHeadingDirective {}
2 changes: 1 addition & 1 deletion apps/app/src/app/shared/theme.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export class ThemeService {
private _systemDarkMode$ = new ReplaySubject<'light' | 'dark' | 'system'>(1);
public darkMode$ = this._darkMode$.asObservable();

private _theme = signal<Theme | undefined>(undefined);
private readonly _theme = signal<Theme | undefined>(undefined);
public theme = this._theme.asReadonly();

constructor() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export class BrnAccordionTriggerComponent implements CustomElementClassSettable
public id = 'brn-accordion-trigger-' + this._item.id;
public ariaControls = 'brn-accordion-content-' + this._item.id;

private _btnClass = signal('');
private readonly _btnClass = signal('');
public btnClass = this._btnClass.asReadonly();

constructor() {
Expand Down
2 changes: 1 addition & 1 deletion libs/ui/accordion/brain/src/lib/brn-accordion.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export class BrnAccordionComponent implements AfterContentInit {
@Input()
public orientation: 'horizontal' | 'vertical' = 'horizontal';

private _openItemIds = signal<number[]>([]);
private readonly _openItemIds = signal<number[]>([]);
public openItemIds = this._openItemIds.asReadonly();
public state = computed(() => (this._openItemIds().length > 0 ? 'open' : 'closed'));
private _keyManager?: FocusKeyManager<BrnAccordionTriggerComponent>;
Expand Down
20 changes: 9 additions & 11 deletions libs/ui/accordion/helm/src/lib/hlm-accordion-content.directive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import {
Directive,
effect,
ElementRef,
HostBinding,
inject,
Injector,
Input,
Expand All @@ -20,6 +19,7 @@ import { ClassValue } from 'clsx';
standalone: true,
host: {
'[style.height]': 'cssHeight()',
'[class]': '_computedClass()',
},
})
export class HlmAccordionContentDirective implements OnInit {
Expand All @@ -28,19 +28,21 @@ export class HlmAccordionContentDirective implements OnInit {
private readonly _injector = inject(Injector);
private readonly _platformId = inject(PLATFORM_ID);

@HostBinding('class')
private _class = this.generateClass();
private _inputs: ClassValue = '';
private _changes?: MutationObserver;

public readonly height = signal('-1');
public readonly cssHeight = computed(() => (this.height() === '-1' ? 'auto' : this.height()));
public readonly state = signal('closed');

private readonly _userCls = signal<ClassValue>('');
@Input()
set class(inputs: ClassValue) {
this._inputs = inputs;
this._class = this.generateClass();
set class(userCls: ClassValue) {
this._userCls.set(userCls);
}

protected _computedClass = computed(() => this._generateClass());
private _generateClass() {
return hlm('overflow-hidden text-sm transition-all', this._userCls());
}

public ngOnInit() {
Expand Down Expand Up @@ -80,8 +82,4 @@ export class HlmAccordionContentDirective implements OnInit {
},
);
}

generateClass() {
return hlm('overflow-hidden text-sm transition-all', this._inputs);
}
}
20 changes: 10 additions & 10 deletions libs/ui/accordion/helm/src/lib/hlm-accordion-icon.component.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Component, HostBinding, Input } from '@angular/core';
import { Component, Input, computed, signal } from '@angular/core';
import { hlm } from '@spartan-ng/ui-core';
import { ClassValue } from 'clsx';

Expand All @@ -10,19 +10,19 @@ import { ClassValue } from 'clsx';
<path stroke-linecap="round" stroke-linejoin="round" d="M19.5 8.25l-7.5 7.5-7.5-7.5" />
</svg>
`,
host: {
'[class]': '_computedClass()',
},
})
export class HlmAccordionIconComponent {
@HostBinding('class')
private _class = this.generateClass();
private _inputs: ClassValue = '';

private readonly _userCls = signal<ClassValue>('');
@Input()
set class(inputs: ClassValue) {
this._inputs = inputs;
this._class = this.generateClass();
set class(userCls: ClassValue) {
this._userCls.set(userCls);
}

generateClass() {
return hlm('inline-block h-4 w-4 transition-transform duration-200', this._inputs);
protected _computedClass = computed(() => this._generateClass());
private _generateClass() {
return hlm('inline-block h-4 w-4 transition-transform duration-200', this._userCls());
}
}
20 changes: 10 additions & 10 deletions libs/ui/accordion/helm/src/lib/hlm-accordion-item.directive.ts
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
import { Directive, HostBinding, Input } from '@angular/core';
import { Directive, Input, computed, signal } from '@angular/core';
import { hlm } from '@spartan-ng/ui-core';
import { ClassValue } from 'clsx';

@Directive({
selector: '[hlmAccordionItem],brn-accordion-item[hlm]',
standalone: true,
host: {
'[class]': '_computedClass()',
},
})
export class HlmAccordionItemDirective {
@HostBinding('class')
private _class = this.generateClass();
private _inputs: ClassValue = '';

private readonly _userCls = signal<ClassValue>('');
@Input()
set class(inputs: ClassValue) {
this._inputs = inputs;
this._class = this.generateClass();
set class(userCls: ClassValue) {
this._userCls.set(userCls);
}

generateClass() {
return hlm('flex flex-1 flex-col border-b border-border', this._inputs);
protected _computedClass = computed(() => this._generateClass());
private _generateClass() {
return hlm('flex flex-1 flex-col border-b border-border', this._userCls());
}
}
23 changes: 12 additions & 11 deletions libs/ui/accordion/helm/src/lib/hlm-accordion-trigger.directive.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Directive, HostBinding, Input } from '@angular/core';
import { Directive, Input, computed, signal } from '@angular/core';
import { hlm, injectCustomClassSettable } from '@spartan-ng/ui-core';
import { ClassValue } from 'clsx';

Expand All @@ -7,32 +7,33 @@ import { ClassValue } from 'clsx';
standalone: true,
host: {
'[style.--tw-ring-offset-shadow]': '"0 0 #000"',
'[class]': '_computedClass()',
},
})
export class HlmAccordionTriggerDirective {
private _host = injectCustomClassSettable({ optional: true });
@HostBinding('class')
private _class = !this._host ? this.generateClass() : '';
private _inputs: ClassValue = '';

constructor() {
this._host?.setClassToCustomElement(this.generateClass());
this._host?.setClassToCustomElement(this._generateClass());
}

private readonly _userCls = signal<ClassValue>('');
@Input()
set class(inputs: ClassValue) {
this._inputs = inputs;
this._userCls.set(inputs);
// cannot set in effect because it sets a signal
if (this._host) {
this._host?.setClassToCustomElement(this._class);
} else {
this._class = this.generateClass();
this._host.setClassToCustomElement(this._generateClass());
}
}

generateClass() {
protected _computedClass = computed(() => {
return !this._host ? this._generateClass() : '';
});
private _generateClass() {
return hlm(
'w-full focus-visible:outline-none text-sm focus-visible:ring-1 focus-visible:ring-ring focus-visible:ring-offset-2 flex flex-1 items-center justify-between py-4 px-0.5 font-medium underline-offset-4 hover:underline [&[data-state=open]>hlm-accordion-icon]:rotate-180',
this._inputs,
this._userCls(),
);
}
}
20 changes: 10 additions & 10 deletions libs/ui/accordion/helm/src/lib/hlm-accordion.directive.ts
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
import { Directive, HostBinding, Input } from '@angular/core';
import { Directive, Input, computed, signal } from '@angular/core';
import { hlm } from '@spartan-ng/ui-core';
import { ClassValue } from 'clsx';

@Directive({
selector: '[hlmAccordion],brn-accordion[hlm]',
standalone: true,
host: {
'[class]': '_computedClass()',
},
})
export class HlmAccordionDirective {
@HostBinding('class')
private _class = this.generateClass();
private _inputs: ClassValue = '';

private readonly _userCls = signal<ClassValue>('');
@Input()
set class(inputs: ClassValue) {
this._inputs = inputs;
this._class = this.generateClass();
set class(userCls: ClassValue) {
this._userCls.set(userCls);
}

generateClass() {
return hlm('flex flex-col', this._inputs);
protected _computedClass = computed(() => this._generateClass());
private _generateClass() {
return hlm('flex flex-col', this._userCls());
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Directive, HostBinding, inject, Input } from '@angular/core';
import { computed, Directive, inject, Input, signal } from '@angular/core';
import { HlmButtonDirective } from '@spartan-ng/ui-button-helm';
import { hlm } from '@spartan-ng/ui-core';
import { ClassValue } from 'clsx';
Expand All @@ -7,23 +7,25 @@ import { ClassValue } from 'clsx';
selector: 'button[hlmAlertDialogCancel]',
standalone: true,
hostDirectives: [HlmButtonDirective],
host: {
'[class]': '_computedClass()',
},
})
export class HlmAlertDialogCancelButtonDirective {
private _hlmBtn = inject(HlmButtonDirective, { host: true });
@HostBinding('class')
_class = this.generateClasses();
private _inputs: ClassValue = '';

private readonly _userCls = signal<ClassValue>('');
@Input()
set class(inputs: ClassValue) {
this._inputs = inputs;
this._class = this.generateClasses();
set class(userCls: ClassValue) {
this._userCls.set(userCls);
}

private generateClasses() {
return hlm('mt-2 sm:mt-0', this._inputs);
}
constructor() {
this._hlmBtn.variant = 'outline';
}

protected _computedClass = computed(() => this._generateClass());
private _generateClass() {
return hlm('mt-2 sm:mt-0', this._userCls());
}
}
Original file line number Diff line number Diff line change
@@ -1,26 +1,26 @@
import { Directive, HostBinding, Input } from '@angular/core';
import { Directive, Input, computed, signal } from '@angular/core';
import { hlm } from '@spartan-ng/ui-core';
import { ClassValue } from 'clsx';

@Directive({
selector: '[hlmAlertDialogClose],[brnAlertDialogClose][hlm]',
standalone: true,
host: {
'[class]': '_computedClass()',
},
})
export class HlmAlertDialogCloseDirective {
@HostBinding('class')
_class = this.generateClasses();
private _inputs: ClassValue = '';

private readonly _userCls = signal<ClassValue>('');
@Input()
set class(inputs: ClassValue) {
this._inputs = inputs;
this._class = this.generateClasses();
set class(userCls: ClassValue) {
this._userCls.set(userCls);
}

private generateClasses() {
protected _computedClass = computed(() => this._generateClass());
private _generateClass() {
return hlm(
'absolute right-4 top-4 [&>hlm-icon]:h-4 [&>hlm-icon]:w-4 rounded-sm opacity-70 ring-offset-background transition-opacity hover:opacity-100 focus:outline-none focus:ring-2 focus:ring-ring focus:ring-offset-2 disabled:pointer-events-none data-[state=open]:bg-accent data-[state=open]:text-muted-foreground',
this._inputs,
this._userCls(),
);
}
}
Loading
Loading