Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accordion trigger doesn't close it content when state open #57

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

oidre
Copy link
Contributor

@oidre oidre commented Nov 19, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • accordion
  • alert
  • alert-dialog
  • aspect-ratio
  • avatar
  • badge
  • button
  • calendar
  • card
  • checkbox
  • collapsible
  • combobox
  • command
  • context-menu
  • data-table
  • date-picker
  • dialog
  • dropdown-menu
  • hover-card
  • input
  • label
  • menubar
  • navigation-menu
  • popover
  • progress
  • radio-group
  • scroll-area
  • select
  • separator
  • sheet
  • skeleton
  • slider
  • switch
  • table
  • tabs
  • textarea
  • toast
  • toggle
  • tooltip
  • typography

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

vercel bot commented Nov 19, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @goetzrobin on Vercel.

@goetzrobin first needs to authorize it.

@goetzrobin
Copy link
Collaborator

Good catch! Can you add an e2e test for this? Happy to help if you need any pointers in how to get up and running with them

@oidre
Copy link
Contributor Author

oidre commented Nov 20, 2023

Good catch! Can you add an e2e test for this? Happy to help if you need any pointers in how to get up and running with them

i don't have experience doing e2e, but let me try

@goetzrobin goetzrobin merged commit 44744d2 into spartan-ng:main Nov 21, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants