fix: abstract injection token creation #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds `createInjectionToken` function to abstract the way we create `InjectionToken`
- `InjectFn` is strongly-typed and has overloads to properly support `{optional: true}`
- `ProvideFn` is strongly-typed version of `{provide, useValue}`
- `ProvideFnExisting` is strongly-typed version of `{provide, useExisting}`
- `TOKEN` is exposed for more manual use-cases
|
Someone is attempting to deploy a commit to a Personal Account owned by @goetzrobin on Vercel. @goetzrobin first needs to authorize it. |
goetzrobin
requested changes
Nov 19, 2023
.../nx/src/generators/ui/libs/ui-dialog-helm/files/lib/hlm-dialog-content.directive.ts.template
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
createInjectionTokenfunction to abstract the way we createInjectionTokenInjectFnis strongly-typed and has overloads to properly support{optional: true}ProvideFnis strongly-typed version of{provide, useValue}ProvideFnExistingis strongly-typed version of{provide, useExisting}TOKENis exposed for more manual use-casesPR Checklist
Please check if your PR fulfills the following requirements:
guidelines: https://github.com/goetzrobin/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Currently, the
InjectionTokeninside ofui-coreis created manually, and the exposedinject***()does not support{ optional: true }properly, leading to various places using Optional Chaining unnecessarily.Closes #
What is the new behavior?
InjectionTokenis created withcreateInjectionTokenDoes this PR introduce a breaking change?
Other information