Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accordion): add exportAs for brnAccordionItem and brnAccordion #539

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

hillin
Copy link
Contributor

@hillin hillin commented Dec 21, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • accordion
  • alert
  • alert-dialog
  • aspect-ratio
  • avatar
  • badge
  • button
  • calendar
  • card
  • checkbox
  • collapsible
  • combobox
  • command
  • context-menu
  • data-table
  • date-picker
  • dialog
  • dropdown-menu
  • hover-card
  • icon
  • input
  • label
  • menubar
  • navigation-menu
  • pagination
  • popover
  • progress
  • radio-group
  • scroll-area
  • select
  • separator
  • sheet
  • skeleton
  • slider
  • sonner
  • spinner
  • switch
  • table
  • tabs
  • textarea
  • toast
  • toggle
  • tooltip
  • typography

What is the current behavior?

Closes #535

What is the new behavior?

BrnAccordionDirective and BrnAccordionItemDirective can now be referenced by template variables with the added exportAs declaration.

e.g.

<div brnAccordion hlm #accordion="brnAccordion">
  <!-- items -->
</div>

{{ accordion.openItemIds() }}

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

It's a simple change, I'm not sure if (and how) this should be tested.

@goetzrobin goetzrobin merged commit 3164754 into spartan-ng:main Dec 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Directives should declare exportAs whenever possible
2 participants