refactor: icon bind to host in decorator #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor to the preferred binding in the decorator. This way also computed is working directly for the binding. addition to issue spartan-ng#46
|
Someone is attempting to deploy a commit to a Personal Account owned by @goetzrobin on Vercel. @goetzrobin first needs to authorize it. |
The classes of the Hostbinding where not set correctly for onPush Hosts. Classes where not merged correctly. Now the classes of the icon are set and detected by the host correctly. fixed unit tests as they would have never failed cause of setTimeout. close spartan-ng#36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
guidelines: https://github.com/goetzrobin/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
icon
What is the current behavior?
generateclasses was called on the setter
Closes #
What is the new behavior?
now the host class is set by a computed
Does this PR introduce a breaking change?
Other information