Add argument 'origins' to Cors docs #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carlosm27 is attempting to deploy a commit to the sparckles Team on Vercel. A member of the Team first needs to authorize it. |
CodSpeed Performance ReportMerging #710 will not alter performanceComparing Summary
|
|
Hey @carlosm27 👋 Thank you for the PR 😄 I just saw this. Is it up for review? |
Hey @sansyrox, don't worry. Yes. |
sansyrox
reviewed
Dec 13, 2023
| @@ -21,14 +21,14 @@ You can allow CORS for your application by adding the following code: | |||
| from robyn import Robyn, ALLOW_CORS | |||
|
|
|||
| app = Robyn(__file__) | |||
| ALLOW_CORS(app) | |||
| ALLOW_CORS(app, origins = "http://localhost:<PORT>/") | |||
There was a problem hiding this comment.
Hey @carlosm27 👋
Thank you for your PRs ✨ but origins is a list[str] and not just a str
sansyrox
approved these changes
Dec 18, 2023
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When allowing CORS, if the is not specify, it will throw this error message:
This PR fixes #