Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Future Roadmap path #675

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Fixing Future Roadmap path #675

merged 2 commits into from
Nov 2, 2023

Conversation

jeasoft
Copy link
Contributor

@jeasoft jeasoft commented Nov 1, 2023

Description
Right Now you get a 404 message when you click Future Roadmap from the Plugin page because the real path is missing. This commit is for fix this.

This PR fixes #679
This fix the path to Future Roadmap from Plugin page (this is the current URL in the that page: https://robyn.tech/documentation/future-roadmap and should be https://robyn.tech/documentation/api_reference/future-roadmap)

Right Now you get a 404 message when you click Future Roadmap from the Plugin page because the real path is missing. This commit is for fix this.
Copy link

vercel bot commented Nov 1, 2023

@jeasoft is attempting to deploy a commit to the sparckles Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@Mr-Sunglasses Mr-Sunglasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @jeasoft ✨, Awesome Work.

@Mr-Sunglasses
Copy link
Contributor

Hey 👋, @jeasoft Could you please open an issue for this PR and link this PR to that issue 😄

@jeasoft
Copy link
Contributor Author

jeasoft commented Nov 1, 2023

Updated in #679. Thanks!

sansyrox
sansyrox previously approved these changes Nov 2, 2023
Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @jeasoft 😄

@sansyrox sansyrox dismissed their stale review November 2, 2023 19:50

conflicts.

@sansyrox
Copy link
Member

sansyrox commented Nov 2, 2023

Hey @jeasoft 👋

Thank you for the PR 😄 But there are some conflicts. Can you please have a look?

@jeasoft
Copy link
Contributor Author

jeasoft commented Nov 2, 2023

Sorry for that, maybe was because I did the changes from here hehe, next time I'll clone the code and make the changes from there.

Copy link

codspeed-hq bot commented Nov 2, 2023

CodSpeed Performance Report

Merging #675 will not alter performance

Comparing jeasoft:patch-1 (c2a0c14) with main (c149ae9)

Summary

✅ 106 untouched benchmarks

@jeasoft
Copy link
Contributor Author

jeasoft commented Nov 2, 2023

Wow @sansyrox now I'm getting a lot of emails, it seems the CI is failing but I didn't change anything to break it.

@sansyrox
Copy link
Member

sansyrox commented Nov 2, 2023

Don't worry @jeasoft 😅 CI failing is temorary

@sansyrox sansyrox merged commit 5497936 into sparckles:main Nov 2, 2023
42 of 57 checks passed
@jeasoft
Copy link
Contributor Author

jeasoft commented Nov 2, 2023

Thanks... and now we are good in the docs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong path for Future Roadmap in the docs
3 participants