Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: suppress clippy warnings #1086

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

sansyrox
Copy link
Member

@sansyrox sansyrox commented Dec 13, 2024

Description

This PR fixes #1080

Summary

This PR fixes warnings of clippy. Will need to revert this change when we update and support python 3.13

PR Checklist

Please ensure that:

  • The PR contains a descriptive title
  • The PR contains a descriptive summary of the changes
  • You build and test your changes before submitting a PR.
  • You have added relevant documentation
  • You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 1:59pm

@sansyrox sansyrox mentioned this pull request Dec 13, 2024
2 tasks
Copy link

codspeed-hq bot commented Dec 13, 2024

CodSpeed Performance Report

Merging #1086 will not alter performance

Comparing fix/clipy-warnings-as-errors (2c02953) with main (0b18882)

Summary

✅ 146 untouched benchmarks

@sansyrox sansyrox merged commit 02d1ce7 into main Dec 13, 2024
62 of 66 checks passed
@sansyrox sansyrox deleted the fix/clipy-warnings-as-errors branch December 13, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci failing because of rust clippy
1 participant