Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: git workflow update macos to macos-latest no other changes #1082

Closed
wants to merge 2 commits into from

Conversation

dave42w
Copy link
Contributor

@dave42w dave42w commented Dec 11, 2024

Description

This PR updates the github workflow from macos-12 (deprecated) to macos-latest

Only affects preview-deployments.yml and release-CI.yml

Summary

This PR does....

PR Checklist

Please ensure that:

  • The PR contains a descriptive title
  • The PR contains a descriptive summary of the changes
  • You build and test your changes before submitting a PR.
  • You have added relevant documentation
  • You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 10:46pm

@sansyrox
Copy link
Member

Hey @dave42w 👋

Could you have a look at this? The CI is failing. :// I have suppressed clippy for a while.

@dave42w
Copy link
Contributor Author

dave42w commented Dec 13, 2024

So it looks like we are missing something that should be build by rust.

I wonder if this is an interconnected thing. Codspeed is failing in this CI because we have not upgraded it to v3 at this point. In codspeed.yml we build for darwin:

     - name: Install dependencies with uv
        run: |
          uv pip install poetry
          uv run poetry export --with test --with dev --without-hashes --output requirements.txt
          uv pip install -r requirements.txt
          uv pip install -e .
      - name: Add macos target
        if: matrix.os == 'macos'
        run: rustup target add aarch64-apple-darwin
      - name: Setup Rust part of the project
        run: |
          maturin build -i python --universal2 --out dist
          uv pip install --no-index --find-links=dist/ robyn

If codspeed is failing then are we adding the darwin target to the maturin build?

Otherwise I have no idea why simply changing the macos version would cause this problem.

Anyway this is the specific error. robyn.cpython-310-darwin.so is not being found. Is there anywhere other than the codspeed.yml that builds this?

 File "<string>", line 1, in <module>
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/robyn/__init__.py", line 13, in <module>
    from robyn.authentication import AuthenticationHandler
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/robyn/authentication.py", line 4, in <module>
    from robyn.robyn import Headers, Identity, Request, Response
ImportError: dlopen(/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/robyn/robyn.cpython-310-darwin.so, 0x0002): tried: '/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/robyn/robyn.cpython-310-darwin.so' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64e' or 'arm64')), '/System/Volumes/Preboot/Cryptexes/OS/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/robyn/robyn.cpython-310-darwin.so' (no such file), '/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/robyn/robyn.cpython-310-darwin.so' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64e' or 'arm64'))
Error: Process completed with exit code 1.

Copy link

codspeed-hq bot commented Dec 15, 2024

CodSpeed Performance Report

Merging #1082 will not alter performance

Comparing dave42w:ci-macos-update (3a7e636) with main (0b18882)

Summary

✅ 146 untouched benchmarks

@sansyrox
Copy link
Member

@dave42w , I am not certain. But I'll give it a shot today.

@sansyrox
Copy link
Member

closing this now.

@sansyrox sansyrox closed this Dec 15, 2024
@sansyrox
Copy link
Member

#1088

updated to mac os 13 as macos-latest had some issues

Thanks thought @dave42w 😄

@dave42w dave42w deleted the ci-macos-update branch December 19, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants