Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute imports in unit tests #312

Merged
merged 1 commit into from
May 5, 2021

Conversation

mcara
Copy link
Member

@mcara mcara commented May 4, 2021

This PR contains only those changes from #310 that pertain to switching unit tests from relative to absolute imports.

The changes to tox.ini will be addressed in #310

@mcara mcara added the testing label May 4, 2021
@mcara mcara requested a review from pllim May 4, 2021 22:50
@mcara mcara self-assigned this May 4, 2021
@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #312 (4824b64) into master (c6623f4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #312   +/-   ##
=======================================
  Coverage   94.85%   94.85%           
=======================================
  Files          14       14           
  Lines        1983     1983           
=======================================
  Hits         1881     1881           
  Misses        102      102           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6623f4...4824b64. Read the comment docs.

@mcara mcara force-pushed the use-relative-imports-in-tests branch from b340f37 to 4824b64 Compare May 4, 2021 23:05
@pllim pllim added this to the 1.1.0 milestone May 5, 2021
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@pllim pllim merged commit 1bf3b48 into spacetelescope:master May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants