-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up Jump detection #229
Merged
WilliamJamieson
merged 30 commits into
spacetelescope:main
from
WilliamJamieson:bugfix/jump_detect_speed
Nov 10, 2023
Merged
Speed up Jump detection #229
WilliamJamieson
merged 30 commits into
spacetelescope:main
from
WilliamJamieson:bugfix/jump_detect_speed
Nov 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know! |
WilliamJamieson
force-pushed
the
bugfix/jump_detect_speed
branch
from
November 9, 2023 23:40
1f18cdf
to
fd8ec01
Compare
kmacdonald-stsci
approved these changes
Nov 10, 2023
schlafly
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. A major refactor!
WilliamJamieson
force-pushed
the
bugfix/jump_detect_speed
branch
from
November 10, 2023 15:44
7878bc0
to
7ac6ccb
Compare
WilliamJamieson
force-pushed
the
bugfix/jump_detect_speed
branch
from
November 10, 2023 18:02
7ac6ccb
to
4e1c872
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR dramatically speeds up Roman's jump detection (and ramp fitting to a lesser extent). Empirical testing locally showed me a speed up from ~33sec to ~6sec for fitting a test data set using jump detection.
The main culprit for this problem was the fact that to use
numpy
one has to jump out of the C code temporally. This overhead was orders of magnitude larger (relative to the expected data sizes, number of resultants per pixel in this case) than just running the computation directly in C using cython commands despite the fact that the numpy implementations of those numerical operations are much more highly optimized. Steps have also been taken to remove an unnecessary calls out of C to python which also has lead to a modest speed improvement.Note that there maybe additional speed improvements by explicitly aligning and indicating the contiguous array dimensions in the memory views.Checklist
CHANGES.rst
(either inBug Fixes
orChanges to API
)