Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JP-3458: Moving ramp_fit CI tests from JWST to STCAL. #228

Merged
merged 6 commits into from
Nov 10, 2023
Merged

JP-3458: Moving ramp_fit CI tests from JWST to STCAL. #228

merged 6 commits into from
Nov 10, 2023

Conversation

kmacdonald-stsci
Copy link
Collaborator

@kmacdonald-stsci kmacdonald-stsci commented Nov 7, 2023 •
edited
Loading

Resolves JP-3458

This PR addresses moves CI tests from JWST to STCAL.

This PR is in conjunction with spacetelescope/jwst#8060, which removed these tests from JWST.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@kmacdonald-stsci kmacdonald-stsci requested a review from a team as a code owner November 7, 2023 17:00
@codecov Codecov
Copy link

codecov bot commented Nov 7, 2023 •
edited
Loading

Codecov Report

Attention: 56 lines in your changes are missing coverage. Please review.

Files Coverage Δ
tests/test_ramp_fitting_cases.py 85.26% <85.26%> (ø)

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!

@hbushouse hbushouse changed the title JP-3458: Removing cases CI tests to be moved to STCAL. JP-3458: Moving ramp_fit CI tests from JWST to STCAL. Nov 8, 2023
WilliamJamieson
WilliamJamieson approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@WilliamJamieson WilliamJamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look fine to me. I would suggest adding the commit hash from jwst, but that probably is not necessary.

WilliamJamieson

This comment was marked as duplicate.

Sign in to view

@kmacdonald-stsci kmacdonald-stsci merged commit d416c8b into spacetelescope:main Nov 10, 2023
24 checks passed
@stscijgbot-jp stscijgbot-jp mentioned this pull request Nov 22, 2023
Closed
@kmacdonald-stsci kmacdonald-stsci deleted the jp_3458 branch July 8, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliamJamieson WilliamJamieson WilliamJamieson approved these changes

@hbushouse hbushouse hbushouse approved these changes

@nden nden Awaiting requested review from nden

@stscieisenhamer stscieisenhamer Awaiting requested review from stscieisenhamer

Assignees
No one assigned
Labels
ramp_fitting testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmacdonald-stsci @hbushouse @WilliamJamieson