Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Add token for codecov #276

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

pllim
Copy link
Contributor

@pllim pllim commented May 15, 2024

Fix #273 (theoretically).

Need to check run master after merge. I don't think this affects PRs from forks because those don't need token for upload.

@pllim pllim added the bug label May 15, 2024
@pllim pllim requested a review from jhunkeler May 15, 2024 18:02
@pllim pllim requested a review from a team as a code owner May 15, 2024 18:02
@mcara
Copy link
Member

mcara commented May 15, 2024

Screenshot 2024-05-15 at 2 11 19 PM even with my approval. Don't know what these required statuses are

@pllim pllim merged commit 125172a into spacetelescope:master May 15, 2024
19 checks passed
@pllim pllim deleted the fix-codecov-upload branch May 15, 2024 18:12
@pllim
Copy link
Contributor Author

pllim commented May 15, 2024

OSX job is throttled because of... reasons.

Since it is irrelevant here, I overrode branch protection and merged it. Thanks for the approval!

@pllim
Copy link
Contributor Author

pllim commented May 15, 2024

Usually the list of jobs has Required tags on the right side if they are required to pass before merge is allowed.

Also see https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches

@pllim
Copy link
Contributor Author

pllim commented May 15, 2024

For completeness, coverage upload is fixed on master. Example log: https://github.com/spacetelescope/spherical_geometry/actions/runs/9100666140/job/25016042691

info - 2024-05-15 18:14:20,573 -- Process Upload complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: codecov upload failed on master
2 participants