Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tox devdeps_npy2 #271

Merged
merged 6 commits into from
May 15, 2024
Merged

Tox devdeps_npy2 #271

merged 6 commits into from
May 15, 2024

Conversation

jhunkeler
Copy link
Contributor

@mcara Did this get rebased out of #265?

@jhunkeler jhunkeler requested a review from a team as a code owner May 15, 2024 10:22
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.33%. Comparing base (125172a) to head (6cd8c78).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #271   +/-   ##
=======================================
  Coverage   80.33%   80.33%           
=======================================
  Files           5        5           
  Lines        1017     1017           
=======================================
  Hits          817      817           
  Misses        200      200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhunkeler jhunkeler force-pushed the tox-devdeps_npy2_1 branch from f393ed8 to 74330bc Compare May 15, 2024 10:26
@jhunkeler jhunkeler changed the title Tox devdeps _npy2 Tox devdeps_npy2 May 15, 2024
tox.ini Outdated Show resolved Hide resolved
pllim

This comment was marked as resolved.

jhunkeler added 2 commits May 15, 2024 12:30
* And numpy 1.x is used otherwise.
* Credit to @pllim for suggesting to use this approach instead
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Thanks!

@mcara mcara merged commit 49f8c89 into spacetelescope:master May 15, 2024
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build wheels Build wheels on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants