-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create github actions #200
Conversation
Please squash out |
run: | | ||
pytest | ||
|
||
doc_build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use RTD PR builder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed .travis.yml
. I renamed the github action blank.yml
to spherical_geometry.yml
.
Also add a badge to README. |
AFAIT there's a consistent issue with the RTD doc builder. I suspect it needs higher permissions to sync the webhook than any of us has. I'll contact someone else about this but meanwhile I think this is OK to go without it. |
Huh! I didn't have that problem with my own |
@mcara I see that the above check for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
At some point in the future if we switch to using tox
here, it might be good to run tests on the installed version of the code, especially since this has a bunch of C code. But that's for a future task I think.
I dunno about tox. I am struggling to get it to find my C-ext over at synphot. No one could figure out why... spacetelescope/synphot_refactor#295 I kinda regret switching to it. |
How should I do this? I removed travis from webhooks but it did not have any effect. @pllim can you advise? Maybe simply merging this PR will remove travis requirement? |
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
=========================================
Coverage ? 65.75%
=========================================
Files ? 8
Lines ? 1244
Branches ? 0
=========================================
Hits ? 818
Misses ? 426
Partials ? 0 Continue to review full report at Codecov.
|
It is under Settings -> Branches (branch protection rules). I updated it to require subset of Actions CI and not Travis CI anymore. |
Looks great! I think this is ready for merging @mcara . |
Created github actions workflow to perform pytests on two python versions, as well as testing a document build.