minor fix for data hash in cache key #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #999 +/- ##
=======================================
Coverage 73.55% 73.55%
=======================================
Files 103 103
Lines 6712 6712
=======================================
Hits 4937 4937
Misses 1775 1775
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ddavis-stsci
approved these changes
Nov 15, 2023
mairanteodoro
pushed a commit
to mairanteodoro/romancal
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a small issue where the test cache does not contain the correct WebbPSF data hash:
This was because the job name defined in the workflow outputs was incorrect.
Checklist
added entry inCHANGES.rstunder the corresponding subsectionupdated relevant documentationran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR