Source detection+PSF docs updates #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #984 +/- ##
=======================================
Coverage 73.55% 73.55%
=======================================
Files 103 103
Lines 6711 6712 +1
=======================================
+ Hits 4936 4937 +1
Misses 1775 1775
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bmorris3
force-pushed
the
source-detect-psf-docs
branch
from
7eb5a61 to
b7efe27
Compare
schlafly
approved these changes
Nov 13, 2023
| @@ -42,7 +44,7 @@ in a parameter file. | |||
| * ``--bkg_boxsize``: If using `calc_threshold_img` size of box in pixels for | |||
| 2D background / threshold images and if using | |||
| calc_threshold_2d, the size of the box used when detecting | |||
| sources. Default is 3. | |||
| sources. Default is 9. | |||
There was a problem hiding this comment.
Good catch! 9 is pretty tiny too. I think we use 256 for the equivalent of this in other surveys!
There was a problem hiding this comment.
This number will still need to be adjusted if there's a crowding, or the source is very bright, etc.
|
I won't update the changelog for this entry until #987 is merged (to avoid a conflict with moving these lines). |
bmorris3
force-pushed
the
source-detect-psf-docs
branch
2 times, most recently
from
e072759 to
8a7cb2f
Compare
bmorris3
force-pushed
the
source-detect-psf-docs
branch
from
8a7cb2f to
437ef0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds narrative docs for users and devs following the introduction of PSF fitting in Source Detection Step (#794, #841). This is a starting point, happy to iterate as reviewers see fit.
Resolves RCAL-708