Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix webbpsf marker #961

Merged

Conversation

WilliamJamieson
Copy link
Collaborator

spacestelescope/stcal#225 is still having failures due to webbpsf. This is due to the fact that a conftest.py was used to register the webbpsf marks and not registering them as a pytest plugin. As a result, these markers are not defined when running pytest from a different location as the top-level conftest.py is not available.

This PR resolves this issue by wrapping the webbpsf marker code into a pytest plugin. Note that webbpsf should probably incorporate this code as it is solving an issue cause by using webbpsf; however, these changes should go in for now to assist upstream packages with downstream testing against romancal.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner October 27, 2023 19:28
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@WilliamJamieson WilliamJamieson merged commit ccf3671 into spacetelescope:main Oct 30, 2023
27 checks passed
@WilliamJamieson WilliamJamieson deleted the bugfix/webbpsf_markers branch October 30, 2023 15:58
ddavis-stsci pushed a commit to ddavis-stsci/romancal that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file no-changelog-entry-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants