Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rcal-697 Update exposure pipeline to add tweakreg step #960

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

ddavis-stsci
Copy link
Collaborator

Resolves RCAL-697

Closes #951

This PR addresses ...

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR
    Jenkins is down the local regression test passes

pytest --bigdata /Users/ddavis/src/Roman/romancal/romancal/regtest/ --basetemp=/Users/ddavis/src/Roman/develop/test/tmp_tc -k test_level2_grism_processing 2>&1 | tee test_pipeline_Oct27_2023_4.log

============================= test session starts ==============================
platform darwin -- Python 3.11.0, pytest-7.4.0, pluggy-1.2.0
rootdir: /Users/ddavis/src/Roman/romancal
configfile: pyproject.toml
plugins: remotedata-0.4.0, asdf-2.15.0, hypothesis-6.82.0, doctestplus-0.13.0, cov-4.1.0, filter-subpackage-0.1.2, mock-3.11.1, astropy-header-0.2.2, anyio-3.7.1, astropy-0.10.0, ci-watson-0.6.1, openfiles-0.5.0, env-0.8.2, arraydiff-0.5.0
collected 32 items / 31 deselected / 1 selected
../../../romancal/romancal/regtest/test_wfi_pipeline.py .                [100%]
=============================== warnings summary ===============================
romancal/regtest/test_wfi_pipeline.py::test_level2_grism_processing_pipeline
  /Users/ddavis/miniconda3/envs/rcal_dev/lib/python3.11/site-packages/asdf/asdf.py:352: AsdfWarning: File 'file:///Users/ddavis/src/Roman/develop/test/tmp_tc/test_level2_grism_processing_p0/r0000201001001001002_01101_0001_WFI01_uncal.asdf' was created with extension class 'asdf.extension.BuiltinExtension' (from package asdf==2.15.1), but older package (asdf==2.15.0) is installed.
    warnings.warn(msg, AsdfWarning)
romancal/regtest/test_wfi_pipeline.py::test_level2_grism_processing_pipeline
  /Users/ddavis/src/Roman/romancal/romancal/refpix/data.py:418: RuntimeWarning: invalid value encountered in divide
    kern = (cov / mask_conv).reshape(rows, columns)
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

========== 1 passed, 31 deselected, 2 warnings in 1233.11s (0:20:33) ===========

The run time warning is from refpix.

Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Files Coverage Δ
romancal/pipeline/exposure_pipeline.py 37.28% <8.69%> (-3.46%) ⬇️

📢 Thoughts on this report? Let us know!.

@ddavis-stsci ddavis-stsci merged commit 650293b into spacetelescope:main Oct 27, 2023
22 of 24 checks passed
@ddavis-stsci ddavis-stsci deleted the rcal-697_dsd branch October 27, 2023 19:31
ddavis-stsci added a commit to ddavis-stsci/romancal that referenced this pull request Nov 7, 2023
…e#960)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include tweakreg in ELP
2 participants