Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add webbpsf and poppy to dev requirements #940

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Oct 13, 2023

As both webbpsf (and poppy used by webbpsf) should now be compatible with numpy 2.0 this PR adds their development versions to requirements-dev-st.txt.

While testing this PR it was revealed that numpy 2.0 was not being installed with the devdeps runs in this PR, changing the numpy requirement to >=2.0.0.dev0 convince pip to install 2.0

The remaining warnings seen in the devdeps jobs do not appear to be related to numpy 2.0 and appear to match the numerous warnings that appear on the non-devdeps runs.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@braingram braingram marked this pull request as ready for review October 16, 2023 14:55
@braingram braingram requested a review from a team as a code owner October 16, 2023 14:55
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@braingram
Copy link
Collaborator Author

Quickly merging while it's all green... :)

@braingram braingram merged commit 1c1d422 into spacetelescope:main Oct 16, 2023
33 checks passed
@braingram braingram deleted the dev_reqs branch October 16, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file no-changelog-entry-needed run devdeps tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants