Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add instructions for downloading WebbPSF data #937

Merged
merged 1 commit into from
Oct 13, 2023
Merged

add instructions for downloading WebbPSF data #937

merged 1 commit into from
Oct 13, 2023

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Oct 12, 2023 •
edited
Loading

WebbPSF data is currently required to run unit tests; this PR adds instructions for making it accessible with the WEBBPSF_PATH environment variable.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@zacharyburnett zacharyburnett self-assigned this Oct 12, 2023
@zacharyburnett zacharyburnett requested a review from a team as a code owner October 12, 2023 18:48
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

braingram
braingram approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zacharyburnett zacharyburnett merged commit 525019b into spacetelescope:main Oct 13, 2023
25 of 27 checks passed
@zacharyburnett zacharyburnett deleted the docs/webbpsf_data branch October 13, 2023 12:15
mairanteodoro pushed a commit to mairanteodoro/romancal that referenced this pull request Oct 13, 2023
@zacharyburnett @mairanteodoro
add instructions for downloading WebbPSF data (spacetelescope#937)
f0b491f
ddavis-stsci pushed a commit to ddavis-stsci/romancal that referenced this pull request Nov 7, 2023
@zacharyburnett @ddavis-stsci
add instructions for downloading WebbPSF data (spacetelescope#937)
0f05f15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braingram braingram braingram approved these changes

Assignees

@zacharyburnett zacharyburnett

Labels
documentation Improvements or additions to documentation no-changelog-entry-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zacharyburnett @braingram