Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min Python to 3.11 per SPEC 0 #1543

Merged

Conversation

WilliamJamieson
Copy link
Collaborator

This PR bumps min python to 3.11 per SPEC 0. astropy 7 has already made this bump.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.associations.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.mosaic_pipeline.rst
  • changes/<PR#>.patch_match.rst

steps

  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.jump_detection.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.flux.rst
  • changes/<PR#>.source_detection.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.resample.rst
  • changes/<PR#>.source_catalog.rst

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner November 26, 2024 16:52
@github-actions github-actions bot added testing dependencies Pull requests that update a dependency file automation labels Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.69%. Comparing base (ec4f412) to head (44ee78f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1543   +/-   ##
=======================================
  Coverage   76.69%   76.69%           
=======================================
  Files         120      120           
  Lines        7830     7830           
=======================================
  Hits         6005     6005           
  Misses       1825     1825           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just since I was not aware, SPEC 0 argues for a 3 yr support window for Python versions, and 3.10 came out toward the end of 2021.

@WilliamJamieson
Copy link
Collaborator Author

LGTM. Just since I was not aware, SPEC 0 argues for a 3 yr support window for Python versions, and 3.10 came out toward the end of 2021.

Originally, astropy was following NEP 29 which has a slightly different schedule. However, it now follows SPEC 0 as recommend by numpy itself. Since one of our core dependencies is astropy it makes sense for us to follow the SPEC 0 schedule along side astropy.

@zacharyburnett zacharyburnett enabled auto-merge (squash) December 2, 2024 16:20
@zacharyburnett
Copy link
Collaborator

@schlafly is this okay with you?

@zacharyburnett zacharyburnett merged commit 6e73a27 into spacetelescope:main Dec 2, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation dependencies Pull requests that update a dependency file testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants