Adding a basic source catalog from Source Detection Step #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1029 +/- ##
==========================================
- Coverage 70.94% 70.90% -0.04%
==========================================
Files 105 105
Lines 6979 6974 -5
==========================================
- Hits 4951 4945 -6
- Misses 2028 2029 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bmorris3
force-pushed
the
photometry-cat
branch
from
2f7278e to
7adddb3
Compare
github-actions
bot
added
pipeline
regression_testing
Wide Field Instrument (WFI)
labels
bmorris3
force-pushed
the
photometry-cat
branch
from
18559d8 to
2cbba5d
Compare
github-actions
bot
removed
pipeline
regression_testing
Wide Field Instrument (WFI)
labels
bmorris3
force-pushed
the
photometry-cat
branch
from
2cbba5d to
f3ca274
Compare
schlafly
reviewed
Dec 4, 2023
|
Regression tests started here |
|
Basic source catalogs got merged in a separate PR by Larry; closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RCAL-719
Closes #1014
This PR does two things:
The data structure originally used for the tweakreg catalog was a 2D ndarray without labels or metadata. Recent PRs have switched to a structured array (Structured array source detection catalogs #987, Fix issue with source catalog in TweakReg. #1001) partly because I was under the impression that an astropy table wasn't supported. I found out that this was incorrect, so this PR saves the tweakreg catalog as an astropy table.
One of the related catalog requirements is to predict if a source is extended or not. There are lots of useful metrics produced but not preserved during Source Detection that help with this task. Sources are found with DAOStarFinder, which estimates source centroids and fluxes, as well as sharpness and roundness metrics. Users can optionally fit PSF models to the image via PSFPhotometry for more accurate astrometry and photometry, which also computes two quality of fit metrics (
qfit, cfit). Those last quality metrics are best described in this ISR or in literature citations that discuss their use like Häberle 2021 or Griggio 2023.Checklist
CHANGES.rstunder the corresponding subsection