Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point tweakreg to new files. Move the asn file into artifactory. #1012

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

schlafly
Copy link
Collaborator

This updates the tweakreg regression test to use new files. It also removes the association file creation logic in favor of adding an association file to artifactory.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.32%. Comparing base (79586ea) to head (429a100).
Report is 515 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1012   +/-   ##
=======================================
  Coverage   73.32%   73.32%           
=======================================
  Files         103      103           
  Lines        6733     6733           
=======================================
  Hits         4937     4937           
  Misses       1796     1796           
Flag Coverage Δ *Carryforward flag
nightly 63.29% <ø> (ø) Carriedforward from 79586ea

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: the suffix for tweakreg should be _tweakreg.asdf. The suffix _tweakregstep is the default when stpipe does not receive rules for constructing the suffix.
We can fix this later.

@schlafly schlafly merged commit da2d16a into spacetelescope:main Nov 20, 2023
31 of 35 checks passed
@schlafly
Copy link
Collaborator Author

Thanks, we'll fix that later. Merging.

@schlafly schlafly deleted the fix-tweakreg-regression branch November 20, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants