Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCAL-919: Formalize the patches (sky cells) file (e.g., add it as a reference file) #524

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/524.feature.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Added schema for skycell reference file.
5 changes: 5 additions & 0 deletions src/rad/resources/manifests/datamodels-1.0.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -513,4 +513,9 @@ tags:
title: MSOS Stack Level 3 Schema
description: |-
Level 3 schema for SSC's MSOS stack products
- tag_uri: asdf://stsci.edu/datamodels/roman/tags/reference_files/roman_skycells-1.0.0
schema_uri: asdf://stsci.edu/datamodels/roman/schemas/reference_files/roman_skycells-1.0.0
title: Schema for the skycell definitions
description: |-
This file contains definitions for all the skycells that cover the entire celestial sphere
...
201 changes: 201 additions & 0 deletions src/rad/resources/schemas/reference_files/roman_skycells-1.0.0.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,201 @@
%YAML 1.1
---
$schema: asdf://stsci.edu/datamodels/roman/schemas/rad_schema-1.0.0
id: asdf://stsci.edu/datamodels/roman/schemas/reference_files/roman_skycells-1.0.0

title: Roman Skycells File Schema
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Roman Skycells File Schema
title: Skycells File Schema

While looking at the roman datamodels PR I noticed the roman prefixes there. Do we need these?
Same goes for the name of this file. Is skycells-1.0.0.yaml sufficient?


datamodel_name: RomanSkycellsRefModel

type: object
properties:
meta:
title: Metadata for Roman Skycells definitions reference file
description: |
The necessary metadata for the Roman Skycells reference file
allOf:
- type: object
properties:
reftype:
title: Reference File Type
description: |
The capitalized string of the reference file type (e.g., DARK).
type: string
enum: [SKYCELLS]
pedigree:
title: Pedigree
description: |
The pedigree of the reference file (e.g., GROUND).
type: string
enum: [GROUND]
description:
title: Description
description: |
A string describing the reference file, its intended usage, etc.
type: string
author:
title: Author
description: |
The author of who or what created the reference file.
type: string
useafter:
title: Use After Date
description: |
The use after date of the reference file for CRDS best references
matching.
tag: tag:stsci.edu:asdf/time/time-1.*
telescope:
title: Telescope
description: |
The telescope data used to select reference files, e.g. ROMAN for the
Nancy Grace Roman Space Telescope.
anyOf:
- tag: asdf://stsci.edu/datamodels/roman/tags/telescope-1.0.0
- type: string
enum: [ROMAN]
origin:
title: Organization
description: |
The organization responsible for creating the file, e.g. STSCI for the
Space Telescope Science Institute.
type: string
instrument:
type: object
properties:
name:
title: Instrument
description: |
The Wide Field Instrument (WFI).
type: string
enum: [WFI]
nxy_skycell:
title: Number of pixels in both x and y dimensions
description: |
The shape of the skycell is (nxy_skycell, nxy_skycell)
type: integer
skycell_border_pixels:
title: The number of pixels in all directions that overlap with the adjacent skycell.
description: |
Within a projection region, skycells are tiled on the same global pixel grid;
this value indicates how many pixels are overlapped in all directions in this tiling.
type: integer
plate_scale:
title: The size of a pixel at the tangent point in arcseconds
description: |
The size of the pixel at the tangent point as projected on the sky in linear pixels for
both directions (e.g., it is assumed equal for both directions).
type: number
projection_regions:
tag: tag:stsci.edu:asdf/core/ndarray-1.*
title: Information about each projection region
description: |
A structured array that contains relevant information about all the projection regions that
cover the entire celestial sphere.
source: 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
source: 0

I'm not aware of any source validator.

datatype:
- name: index
datatype: int32
byteorder: little
- name: ra_tangent
datatype: float64
byteorder: little
- name: dec_tangent
datatype: float64
byteorder: little
- name: ra_min
datatype: float64
byteorder: little
- name: ra_max
datatype: float64
byteorder: little
- name: dec_min
datatype: float64
byteorder: little
- name: dec_max
datatype: float64
byteorder: little
- name: orientat
datatype: float32
byteorder: little
- name: x_tangent
datatype: float64
byteorder: little
- name: y_tangent
datatype: float64
byteorder: little
- name: nx
datatype: int32
byteorder: little
- name: ny
datatype: int32
byteorder: little
- name: skycell_start
datatype: int32
byteorder: little
- name: skycell_end
datatype: int32
byteorder: little
- name: nxy_skycell
datatype: int32
byteorder: little
- name: skycell_border_pixels
datatype: int32
byteorder: little
- name: pixel_scale
datatype: float32
byteorder: little
exact_datatype: true
skycells:
tag: tag:stsci.edu:asdf/core/ndarray-1.*
title: Information about all skycells
description: |
Relevant information about all skycells that have been defined to cover the celesital sphere.
source: 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
source: 1

Same as above

datatype:
- name: name
datatype: [ucs4, 16]
byteorder: little
- name: ra_center
datatype: float64
byteorder: little
- name: dec_center
datatype: float64
byteorder: little
- name: orientat
datatype: float32
byteorder: little
- name: x_tangent
datatype: float64
byteorder: little
- name: y_tangent
datatype: float64
byteorder: little
- name: ra_corn1
datatype: float64
byteorder: little
- name: dec_corn1
datatype: float64
byteorder: little
- name: ra_corn2
datatype: float64
byteorder: little
- name: dec_corn2
datatype: float64
byteorder: little
- name: ra_corn3
datatype: float64
byteorder: little
- name: dec_corn3
datatype: float64
byteorder: little
- name: ra_corn4
datatype: float64
byteorder: little
- name: dec_corn4
datatype: float64
byteorder: little
exact_datatype: true
required: [meta, projection_regions, skycells]
flowStyle: block
propertyOrder: [meta, projection_regions, skycells]
...
Loading