switch tag keywords for external tags to wildcards

[braingram]

This PR switches the tag keywords in the rad schemas to wildcard expressions for all tags outside of rad. For example:

rad/src/rad/resources/schemas/wfi_image-1.0.0.yaml

Line 34 in 64cf407

tag: tag:stsci.edu:asdf/core/ndarray-1.0.0

is replaced by

 tag: tag:stsci.edu:asdf/core/ndarray-1.*

The use of the wildcard * means that any ndarray tag with a version starting with 1. will be considered valid.

This change is needed for asdf standard 1.6.0 (the current development version and upcoming stable version) which contains an increase in the ndarray tag version (from 1.0.0 to 1.1.0). Many other tags will also see version changes to comply with 1.6.0 (including time, quantity, etc).

The type of failure that this PR will avoid can be seen in the following example:

import roman_datamodels.maker_util
n = roman_datamodels.maker_utils.mk_node(roman_datamodels.stnode.WfiImage)
m = roman_datamodels.datamodels.ImageModel(n)
m.save('foo.asdf', version='1.6.0')  # the version is provided here as the current default is 1.5.0

which results in an error:

ValidationError: mismatched tags, wanted 'tag:stsci.edu:asdf/time/time-1.1.0', got 'tag:stsci.edu:asdf/time/time-1.2.0'

Regression tests passed: https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FRoman-Developers-Pull-Requests/detail/Roman-Developers-Pull-Requests/598/pipeline/247

Checklist

• Schema changes discussed at RAD Review Board meeting
• Added entry in CHANGES.rst under the corresponding subsection
• Updated relevant roman_datamodels utilities and tests
• Passed romancal regression testing on Jenkins / PLWishMaster. Link: https://plwishmaster.stsci.edu:8081/job/RT/job/romancal/XXX/

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f40287) 95.32% compared to head (21496b7) 95.32%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #370   +/-   ##
=======================================
  Coverage   95.32%   95.32%           
=======================================
  Files           4        4           
  Lines         171      171           
=======================================
  Hits          163      163           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[WilliamJamieson]

One question.

[WilliamJamieson]

If I recall how this gets used, with this change the use of external tags with a 1.* version instead of a 1.0.0 (or whatever version) will be enforced by this test. Can you confirm that we get test failures if a tag a non * version external tag is used?

[braingram]

Thanks for taking a look! Your recollection is spot-on. I made a draft PR which changes time-1.* to time-1.0 in the exposure schema (see commit). This causes the mentioned test to fail with:

E           AssertionError: assert 'tag:stsci.edu:asdf/time/time-1.0.0' in {'asdf://stsci.edu/datamodels/roman/tags/aperture-1.0.0', 'asdf://stsci.edu/datamodels/roman/tags/associations-1.0.0',...models/roman/tags/calibration_software_version-1.0.0', 'asdf://stsci.edu/datamodels/roman/tags/coordinates-1.0.0', ...}

See: https://github.com/spacetelescope/rad/actions/runs/7846209023/job/21412354776?pr=371#step:10:104

[WilliamJamieson]

Thanks, I wanted to make sure that future changes wouldn't slowly undo this work.

[WilliamJamieson]

Please do a regression test run. It should not cause any issues, but with the impending build release its better to be safe.

[braingram]

Thanks again! The regression tests passed without issue:
https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FRoman-Developers-Pull-Requests/detail/Roman-Developers-Pull-Requests/598/pipeline/247

[WilliamJamieson]

@PaulHuwe please let us know if your happy with these changes.

[PaulHuwe]

LGTM. Please confirm with @ddavis-stsci before merging (or merge after the release).

[braingram]

@ddavis-stsci I updated this PR moving the changelog entry to 0.19.1 (unreleased). As the 0.19.0 release is out any objection to merging this PR?

[ddavis-stsci]

Since 0.19.0 is out merging this should be fine.

[braingram]

It appears I do not have write access to this repository so please feel free to merge whenever.

[PaulHuwe]

Merged.